Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim vg (uplift to 1.5.x) #4921

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Claim vg (uplift to 1.5.x) #4921

merged 2 commits into from
Mar 13, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 12, 2020

Uplift of #4708

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kjozwiak
Copy link
Member

@NejcZdovc looks like the build part has failed on all the platforms.

@NejcZdovc NejcZdovc force-pushed the claim-vg-1.5 branch 5 times, most recently from 13f0c0e to 19115af Compare March 13, 2020 14:25
@NejcZdovc
Copy link
Contributor Author

CI failed on not related things

@NejcZdovc NejcZdovc requested a review from a team March 13, 2020 21:08
@NejcZdovc NejcZdovc changed the title Claim vg 1.5 Claim vg (uplift to 1.5.x) Mar 13, 2020
@kjozwiak
Copy link
Member

Looks like most of the failures where due to lint failing. However, this is a known issue and will be resolved via brave/brave-browser#8684.

Android failing lint --> https://ci.brave.com/job/brave-browser-build-pr/job/claim-vg-1.5/7/execution/node/296/log/
iOS failing lint --> https://ci.brave.com/job/brave-browser-build-pr/job/claim-vg-1.5/7/execution/node/541/log/
Linux failing lint --> https://ci.brave.com/job/brave-browser-build-pr/job/claim-vg-1.5/7/execution/node/212/log/
macOS failing lint --> https://ci.brave.com/job/brave-browser-build-pr/job/claim-vg-1.5/7/execution/node/658/log/

Looks like audit_deps failed on Win x64 due to ENOAUDIT which is a known issue not related to this specific PR as per #4921 (comment).

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. As per #4921 (comment), lint failed on all the platforms which is expected. The failure isn't related to this particular PR and has already beed addressed. QA has also run through the PR as per #4708 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit e384180 into 1.5.x Mar 13, 2020
@kjozwiak kjozwiak deleted the claim-vg-1.5 branch March 13, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants