Enforce licenses in third_party code added to brave-core #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
force-pushed
the
enforce_missing_brave_licenses-9408
branch
2 times, most recently
from
5e0d785
to
7999e51
Compare
|
Restarted CI after brave/brave-browser#9431 was merged 😄 |
fmarier
force-pushed
the
enforce_missing_brave_licenses-9408
branch
from
7999e51
to
13d5406
Compare
fmarier
commented
Apr 24, 2020
| for path in third_party_dirs: | ||
| try: | ||
| metadata = ParseDir(path, _REPOSITORY_ROOT) | ||
| - except LicenseError: |
There was a problem hiding this comment.
This code is very unlikely to change since https://bugs.chromium.org/p/chromium/issues/detail?id=39240 has been open for 10 years. That said, if it did change due to this bug being fixed, we would then simply be able to drop this patch hunk entirely.
29 tasks
fmarier
force-pushed
the
enforce_missing_brave_licenses-9408
branch
3 times, most recently
from
eb57b3f
to
b4e6cb9
Compare
fmarier
force-pushed
the
enforce_missing_brave_licenses-9408
branch
7 times, most recently
from
db55000
to
aa7b503
Compare
bridiver
approved these changes
May 8, 2020
fmarier
force-pushed
the
enforce_missing_brave_licenses-9408
branch
3 times, most recently
from
16adf72
to
f905f3c
Compare
This should have been added when the extra dependency was added in 9cc23dd.
This add the missing license (brave/extension-whitelist#20) and whitelists 1PasswordX (fixes brave/extension-whitelist#18), TabDefrag (fixes brave/extension-whitelist#21), and GNOME Shell integration (fixes brave/extension-whitelist#26).
fmarier
force-pushed
the
enforce_missing_brave_licenses-9408
branch
from
f905f3c
to
f020ffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#9408.
It depends on #5332.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Open
brave://creditsand look for:They should all have an entry on that page with a license and a working link.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.