Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to import chrome data w/o warning dialog #5336

Merged
merged 3 commits into from
May 14, 2020
Merged

Try to import chrome data w/o warning dialog #5336

merged 3 commits into from
May 14, 2020

Commits on May 12, 2020

  1. Just warning if browser detect chrome is running while importing 

    With this warning dialog, user will close chrome windows.
After that user clicks continue button, browser will not check lock again aind
will try to import chrome's settings.
Even if chrome is still running, importing will be done because
importing is done with temporarily copied db files.
    @simonhong
    simonhong committed May 12, 2020
    Configuration menu
    Copy the full SHA
    c26d326 View commit details
    Browse the repository at this point in the history

  2. Don't show warning dialog while importing 

    Browser will try to import data w/o warning about closing currently
running chrome instance.
    @simonhong
    simonhong committed May 12, 2020
    Configuration menu
    Copy the full SHA
    ded84b5 View commit details
    Browse the repository at this point in the history

  3. Handle temp file copy failure

    @simonhong
    simonhong committed May 12, 2020
    Configuration menu
    Copy the full SHA
    38b53f3 View commit details
    Browse the repository at this point in the history