Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent crash in Confirmations due to invalid wallet #5347

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 23, 2020

Resolves brave/brave-browser#8535

Submitter Checklist:

Test Plan:

  • Confirm confirmation tokens are refilled
  • Confirm users are rewarded for viewing an ad
  • Confirm confirmations are cashed-out
  • Confirm "Estimated rewards pending" and "Ad notifications received this month" in ads rewards show the correct values (also after a restarting the browser)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewards code looks good

@bsclifton
Copy link
Member

Restarted CI after brave/brave-browser#9431 was merged 😄

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 24, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Apr 24, 2020

Failed on iOS restarting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent crash in Confirmations due to invalid wallet
4 participants