Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Show Background Image" to "Show Background Images" on NTP under Background Settings #5627

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

0xedward
Copy link
Contributor

@0xedward 0xedward commented May 22, 2020

Update Show Background Image text under Background Settings on New Tab Page to Show Background Images

Resolves brave/brave-browser#7947

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

image

@0xedward 0xedward changed the title Change "Show Background Image" to "Show Background Images" on NTP Change "Show Background Image" to "Show Background Images" on NTP under Background Settings May 22, 2020
@0xedward 0xedward force-pushed the ntp-update-show-background-image branch from 5bba43c to a5968ff Compare May 27, 2020 19:07
@bsclifton bsclifton self-requested a review September 4, 2020 07:46
@bsclifton bsclifton added this to the 1.15.x - Nightly milestone Sep 4, 2020
@bsclifton
Copy link
Member

LGTM 👍 Sorry for the super long turn-around here ☹️

@bsclifton bsclifton merged commit ae8e9e1 into brave:master Sep 4, 2020
@0xedward 0xedward deleted the ntp-update-show-background-image branch October 2, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text update needed on Dashboard Settings
2 participants