Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving lost stack widget issue #5982

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Resolving lost stack widget issue #5982

merged 1 commit into from
Jul 6, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jun 30, 2020

Fixes: brave/brave-browser#10067

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.12.x - Nightly milestone Jun 30, 2020
@ryanml ryanml requested review from bbondy and emerick June 30, 2020 21:59
@ryanml ryanml self-assigned this Jun 30, 2020
@@ -140,18 +141,13 @@ export const newTabReducer: Reducer<NewTab.State | undefined> = (state: NewTab.S
break
}

widgetStackOrder = widgetStackOrder.filter((curWidget: NewTab.StackWidget) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really wasn't necessary given current architecture

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml
Copy link
Contributor Author

ryanml commented Jul 6, 2020

CI Failure unrelated:

[  FAILED  ] RewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (1521 ms)
[608/609] RewardsBrowserTest.NotVerifiedWallet (1831 ms)
[609/609] RewardsContributionBrowserTest.PanelDefaultMonthlyTipChoices (1306 ms)
1 test failed:
     RewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:236)
null

@ryanml ryanml merged commit c0177ed into master Jul 6, 2020
@ryanml ryanml deleted the fix-10067 branch July 6, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Enabling Brave Rewards widget via settings page doesn't enable it in NTP
2 participants