Cross promotional modal dp #6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-linux
CI/skip-macos-x64
samartnik
requested changes
Jul 22, 2020
| Brave works everywhere | ||
| </message> | ||
| <message name="IDS_DOWNLOAD_BRAVE" desc="Cross promotional modal text"> | ||
| Download Brave at brave.com on your laptop ot tablet for a faster and more private web |
There was a problem hiding this comment.
oops sorry. it's a typo. i will update it
| Download Brave at brave.com on your laptop ot tablet for a faster and more private web | ||
| </message> | ||
| <message name="IDS_BRAVE_URL" desc="Brave url"> | ||
| brave.com |
There was a problem hiding this comment.
Not sure if we need it as string here as it doesn't require translation
There was a problem hiding this comment.
i agree. i will remove it from strings and add it in the class as constant
samartnik
reviewed
Jul 22, 2020
| ss.setSpan(foregroundSpan, indexOfSpan, | ||
| (indexOfSpan + getResources().getString(R.string.brave_url).length()), Spanned.SPAN_EXCLUSIVE_EXCLUSIVE); | ||
| mCrossPromoText.setText(ss); | ||
|
|
samartnik
reviewed
Jul 22, 2020
| params.height = LinearLayout.LayoutParams.WRAP_CONTENT; | ||
| getDialog().getWindow().setAttributes(params); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: in chromium they add empty line at the end of java files, I think we should do it too for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : brave/brave-browser#10571
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Follow the test plan on the issue and follow https://www.figma.com/file/atoL4LN2kd8ILnPGwohUoV/Mobile-onboarding-v2?node-id=697%3A5848 for the design spec
Reviewer Checklist:
After-merge Checklist:
changes has landed on.