Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Brave Ads intermittently crashes when opening a new tab - 1.13.x #6309

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Fixes Brave Ads intermittently crashes when opening a new tab - 1.13.x #6309

merged 1 commit into from
Aug 6, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 1, 2020 •
edited by kjozwiak
Loading

Uplift of #6304
Resolves brave/brave-browser#9393

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team August 1, 2020 07:16
@tmancey tmancey self-assigned this Aug 1, 2020
@tmancey tmancey changed the title Fixes Brave Ads intermittently crashes when opening a new tab Fixes Brave Ads intermittently crashes when opening a new tab - 1.13.x Aug 1, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 4, 2020

CI failed for known Brave Rewards browser test issue

@kjozwiak
Copy link
Member

kjozwiak commented Aug 4, 2020 •
edited
Loading

Currently PR/Blocked due to not being able to QA #6305 until #6248 has been fixed on Nightly.

@LaurenWags
Copy link
Member

Linux failed due to RewardsBrowserTest.NotVerifiedWallet (https://ci.brave.com/job/pr-brave-browser-issues-9393-1.13.x/2/execution/node/430/log/) which is a known issue and does not block uplift.

kjozwiak
kjozwiak approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6304 (comment).

@kjozwiak kjozwiak merged commit 246266c into 1.13.x Aug 6, 2020
@kjozwiak kjozwiak deleted the issues/9393-1.13.x branch August 6, 2020 07:47
@kjozwiak kjozwiak added this to the 1.13.x - Beta milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @kjozwiak @LaurenWags