Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persists widget menus when they aren't in the foreground #6327

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 4, 2020

Fixes brave/brave-browser#10199, brave/brave-browser#10749

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had a chance to test but code looks pretty good!

@ryanml
Copy link
Contributor Author

ryanml commented Aug 6, 2020

CI failures unrelated

@ryanml ryanml merged commit 761cd41 into master Aug 6, 2020
@ryanml ryanml deleted the fix-10199-2 branch August 6, 2020 08:51
ryanml added a commit that referenced this pull request Aug 7, 2020
Persists widget menus when they aren't in the foreground
ryanml added a commit that referenced this pull request Aug 14, 2020
Persists widget menus when they aren't in the foreground
@LaurenWags
Copy link
Member

Verified brave/brave-browser#10749 using

Brave | 1.14.45 Chromium: 85.0.4183.69 (Build officiel) nightly (64 bits)
-- | --
Révision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
Système d'exploitation | macOS Version 10.14.6 (assemblage 18G3020)

French
French

German
German

English
English

@kjozwiak
Copy link
Member

Verification re: https://github.com/brave/brave-browser/issues/10199

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.14.45 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.15.6 (Build 19G73)

NTPwidgets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Unable to use menu items for stacked widgets
5 participants