Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP Settings Dashboard, widget menu fixes (1.13) #6372

Merged
merged 2 commits into from
Aug 17, 2020
Merged

NTP Settings Dashboard, widget menu fixes (1.13) #6372

merged 2 commits into from
Aug 17, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 7, 2020 •
edited by kjozwiak
Loading

Uplift of: #6351, #6327
Fixes: brave/brave-browser#11103, brave/brave-browser#10199, brave/brave-browser#10749

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml ryanml added this to the 1.13.x - Beta milestone Aug 7, 2020
@ryanml ryanml requested a review from a team August 7, 2020 09:03
@ryanml ryanml self-assigned this Aug 7, 2020
@ryanml
Merge pull request #6327 from brave/fix-10199-2
7413964 
Persists widget menus when they aren't in the foreground
@ryanml
Merge pull request #6351 from brave/fix-11103
7363519 
NTP Settings Design Fixes
@kjozwiak kjozwiak mentioned this pull request Aug 17, 2020
Merged
32 tasks
kjozwiak
kjozwiak approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PRs on Nightly as per #6351 (comment), #6327 (comment) and #6327 (comment).

@kjozwiak kjozwiak merged commit aef61f0 into 1.13.x Aug 17, 2020
@kjozwiak kjozwiak deleted the menu-fixes-1.13 branch August 17, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
feature/crypto-widgets feature/newtab
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak