Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes user funds claim #6442

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fixes user funds claim #6442

merged 1 commit into from
Aug 18, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 18, 2020

Resolves brave/brave-browser#11298

Submitter Checklist:

Test Plan:

  • defined in the issue
  • make sure that claim works with user funds and VG
  • make sure that claim works with 0 balance

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc requested a review from a team August 18, 2020 15:58
@NejcZdovc NejcZdovc self-assigned this Aug 18, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team August 18, 2020 15:58
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Aug 18, 2020
@NejcZdovc NejcZdovc merged commit cf12bc9 into master Aug 18, 2020
@NejcZdovc NejcZdovc deleted the user_funds_claim branch August 18, 2020 21:08
@LaurenWags
Copy link
Member

Verified passed with

Brave	1.15.6 Chromium: 85.0.4183.78 (Official Build) nightly (64-bit)
Revision	720ec01a54ea94d2d8b7a1d273e0fa89722fb11b-refs/branch-heads/4183@{#1603}
OS	macOS Version 10.14.6 (Build 18G3020)

Scenario 1 - Verified STR from brave/brave-browser#11298 (comment) - PASSED

Clean profile with above version. Enabled rewards, restored wallet with anon user funds.
UF1

Connected KYC'd user wallet. Confirmed seeing the below in my logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Method: UrlMethod::POST
> Content: ...

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Result: Success
> HTTP Code: 200
> Body: null

Confirmed anon BAT moved to Uphold:
UF4
UF2
UF3

Scenario 2 - make sure that claim works with user funds and VG - PASSED

Clean profile with above version, enable rewards. Restore a wallet with user funds and an Ad grant. Claim Ad grant.
UF-VG1b
UF-VG1a

Connect KYC'd user wallet. Confirmed seeing the below in my logs:

> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Method: UrlMethod::POST
> Content: ...

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Result: Success
> HTTP Code: 200
> Body: null

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: 

Confirmed all BAT (user funded and Ad grant) moved to Uphold:
UF-VG2
UF-VG4
UF-VG3

Scenario 3 - make sure that claim works with 0 balance - PASSED

Clean profile with above version, enable rewards.
0bal-1a
0bal-1b

Connect KYC'd user wallet. Confirmed seeing the below in my logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Method: UrlMethod::POST
> Content: ...

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/redacted/claim
> Result: Success
> HTTP Code: 200
> Body: null

0bal-2

0bal-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] user funds do not move to Uphold - follow up to 8428
4 participants