Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check result of seed derivation from passphrase #656

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Correctly check result of seed derivation from passphrase #656

merged 1 commit into from
Oct 17, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Oct 17, 2018

Fixes brave/brave-browser#1636

in brave-intl/bat-native-ledger#146

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler merged commit 97fc2ec into brave:master Oct 17, 2018
jasonrsadler pushed a commit that referenced this pull request Oct 17, 2018
Correctly check result of seed derivation from passphrase
jasonrsadler pushed a commit that referenced this pull request Oct 17, 2018
Correctly check result of seed derivation from passphrase
jasonrsadler pushed a commit that referenced this pull request Oct 17, 2018
Correctly check result of seed derivation from passphrase
@jasonrsadler
Copy link
Contributor Author

master: 97fc2ec
0.55: e0dc2c5
0.56: 4a26b81
0.57: 23ae176

@jasonrsadler jasonrsadler deleted the seed-deriv-check branch October 17, 2018 02:29
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Upgrade to Chromium 69.0.3497.12
petemill pushed a commit that referenced this pull request Jul 27, 2020
Upgrade to Chromium 69.0.3497.12
petemill pushed a commit that referenced this pull request Jul 28, 2020
Upgrade to Chromium 69.0.3497.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix check for passphrase to seed derivation in BatClient::continueRecover
2 participants