Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent connections to www.gstatic.com plugins_mac.json #680

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 18, 2018

...and related per platform files

Marked as work in progress until I get final signoff from @jumde and @bkero for the URL to use here.

Fix brave/brave-browser#1684

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Oct 18, 2018
@bbondy bbondy requested review from bkero and jumde October 18, 2018 04:01
@bbondy bbondy changed the title WIP: Prevent connections to www.gstatic.com plugins_mac.json Prevent connections to www.gstatic.com plugins_mac.json Oct 18, 2018
@jumde
Copy link
Contributor

jumde commented Oct 18, 2018

screen shot 2018-10-18 at 5 34 29 am

@NejcZdovc NejcZdovc merged commit 7b869fb into master Oct 18, 2018
@NejcZdovc NejcZdovc deleted the plugins_3 branch October 18, 2018 12:36
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Prevent connections to www.gstatic.com plugins_mac.json
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Prevent connections to www.gstatic.com plugins_mac.json
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Prevent connections to www.gstatic.com plugins_mac.json
@NejcZdovc
Copy link
Contributor

master 7b869fb
0.57.x d549184
0.56.x 1c8a4bf
0.55.x 89b9c71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent connections to www.gstatic.com/chrome/config/plugins_3/plugins_mac.json and related per platform files
3 participants