Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes upgrade path #687

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Fixes upgrade path #687

merged 1 commit into from
Oct 18, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 18, 2018

Resolves brave/brave-browser#1657

Ledger implementation brave-intl/bat-native-ledger#150

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • create profile with rewards enabled on 55.12
  • start 55.14
  • make sure that nothing is broken

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

bbondy
bbondy previously approved these changes Oct 18, 2018
@NejcZdovc NejcZdovc merged commit 549fe7d into master Oct 18, 2018
@NejcZdovc NejcZdovc deleted the upgrade-path branch October 18, 2018 12:23
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
@NejcZdovc
Copy link
Contributor Author

master 549fe7d
0.57.x 43e9864
0.56.x ff42138
0.55.x 61ed7bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed Contribution Dates
2 participants