Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds wallet creation failed flow #689

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Adds wallet creation failed flow #689

merged 2 commits into from
Oct 18, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 18, 2018

Resolves brave/brave-browser#1687

UI implementation: brave/brave-ui#222

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • make sure that you see creating wallet and spinner
  • make sure that wallet is created
  • turn internet off
  • enable rewards
  • make sure that you get alert
  • click on try again
  • make sure that you still have alert and button say yes I am in
  • turn on internet
  • click on try again or yes I am in
  • make sure that wallet is crated

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

bbondy
bbondy previously approved these changes Oct 18, 2018
@NejcZdovc NejcZdovc merged commit db5a6d1 into master Oct 18, 2018
@NejcZdovc NejcZdovc deleted the wallet-failed branch October 18, 2018 12:24
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Adds wallet creation failed flow
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Adds wallet creation failed flow
NejcZdovc added a commit that referenced this pull request Oct 18, 2018
Adds wallet creation failed flow
@NejcZdovc
Copy link
Contributor Author

master db5a6d1
0.57.x 808c767
0.56.x 82b7f22
0.55.x 0587bfd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to enable Rewards when offline permanently breaks it
2 participants