Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes includes violation from components to browser at brave_sync_profile_sync_service.cc #7107

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

Resolves brave/brave-browser#12614

Submitter Checklist:

Test Plan:

N/A

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner November 10, 2020 18:01
@AlexeyBarabash AlexeyBarabash self-assigned this Nov 10, 2020
@AlexeyBarabash AlexeyBarabash added this to the 1.18.x - Nightly milestone Nov 10, 2020
@AlexeyBarabash
Copy link
Contributor Author

AlexeyBarabash commented Nov 10, 2020

Linux CI run is UNSTABLE, failed


23:31:59  1 test failed:
23:31:59      SearchEngineProviderP3ATest.DefaultSearchEngineP3A (../../brave/browser/search_engines/search_engine_tracker_browsertest.cc:34)
23:31:59  null

not related to this PR

but quite interesting as I published another PR related to P3A #7016 :)

@AlexeyBarabash
Copy link
Contributor Author

All CI are green after restarted Windows

@AlexeyBarabash AlexeyBarabash merged commit 6d05f22 into master Nov 11, 2020
@AlexeyBarabash AlexeyBarabash deleted the fix_violating_includes branch November 11, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer violation for includes at brave_sync_profile_sync_service.cc
3 participants