From efc05f0225add8417896f19459d28fa1a49831ea Mon Sep 17 00:00:00 2001 From: Brian Clifton Date: Tue, 2 Feb 2021 12:57:24 -0700 Subject: [PATCH] Stats updater URL fixes - check stats updater URL in GN to fail quick. - remove check which causes crash since GN check is done. Fixes https://github.com/brave/brave-browser/issues/13858 --- browser/brave_stats/BUILD.gn | 2 ++ browser/brave_stats/brave_stats_updater.cc | 8 +------- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/browser/brave_stats/BUILD.gn b/browser/brave_stats/BUILD.gn index 2ecd79de3992..9d9f1eac8eb9 100644 --- a/browser/brave_stats/BUILD.gn +++ b/browser/brave_stats/BUILD.gn @@ -4,6 +4,8 @@ declare_args() { brave_stats_updater_url = "" } +if (is_official_build) { assert(brave_stats_updater_url != "") } + source_set("stats_updater") { # Remove when https://github.com/brave/brave-browser/issues/10657 is resolved check_includes = false diff --git a/browser/brave_stats/brave_stats_updater.cc b/browser/brave_stats/brave_stats_updater.cc index e63d61fa9941..403acd989f0c 100644 --- a/browser/brave_stats/brave_stats_updater.cc +++ b/browser/brave_stats/brave_stats_updater.cc @@ -173,13 +173,7 @@ void BraveStatsUpdater::SetStatsThresholdCallback( } GURL BraveStatsUpdater::BuildStatsEndpoint(const std::string& path) { - auto stats_updater_url = GURL(usage_server_ + path); -#if defined(OFFICIAL_BUILD) - if(!stats_updater_url.is_valid()) { - LOG(ERROR) << "stats_updater_url is not valid! " << stats_updater_url; - } -#endif - return stats_updater_url; + return GURL(usage_server_ + path); } void BraveStatsUpdater::OnSimpleLoaderComplete(