Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the current extension popup when using ShowActionUI #7935

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#14110
Resolves brave/brave-browser#14108

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test plans specified in linked issues.

@zenparsing zenparsing requested a review from a team as a code owner February 11, 2021 18:51
@zenparsing zenparsing self-assigned this Feb 11, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 0ca4e6a into master Feb 12, 2021
@zenparsing zenparsing deleted the ksmith-bap-ui-crash branch February 12, 2021 01:24
brave-builds pushed a commit that referenced this pull request Feb 12, 2021
@zenparsing zenparsing added this to the 1.22.x - Nightly milestone Feb 12, 2021
zenparsing added a commit that referenced this pull request Feb 12, 2021
bsclifton added a commit that referenced this pull request Feb 18, 2021
This reverts commit 0ca4e6a, reversing
changes made to f778962.
This was referenced Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants