Remove placeholder on NTP #8241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-linux
CI/skip-macos-x64
samartnik
requested changes
Mar 13, 2021
| @@ -22,6 +22,13 @@ public BraveNewTabPageLayoutClassAdapter(ClassVisitor visitor) { | |||
| deleteField(sBraveNewTabPageLayoutClassName, "mSiteSectionView"); | |||
| makeProtectedField(sNewTabPageLayoutClassName, "mSiteSectionView"); | |||
|
|
|||
| deleteField(sBraveNewTabPageLayoutClassName, "mTileGroup"); | |||
| makeProtectedField(sNewTabPageLayoutClassName, "mTileGroup"); | |||
There was a problem hiding this comment.
Please add unit test for this field
| deleteField(sBraveNewTabPageLayoutClassName, "mTileGroup"); | ||
| makeProtectedField(sNewTabPageLayoutClassName, "mTileGroup"); | ||
|
|
||
| makePublicMethod(sNewTabPageLayoutClassName, "updateTileGridPlaceholderVisibility"); |
There was a problem hiding this comment.
Please add unit test for this method
|
Removing this from |
Remove warning regarding placeholder
deeppandya
force-pushed
the
remove_ntp_placeholder_android
branch
from
c14f6c4
to
c49590b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove warning regarding placeholder
Resolves brave/brave-browser#14662
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: