Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/brave/brave-browser/issues/14289 #8242

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Mar 13, 2021

Resolves brave/brave-browser#14289

Instagram is owned by Facebook, currently the Facebook login will redirect to a blank page.

I had to rebase the previous PR. this will work. Will retest the CI build, but it'll allow instagram to use facebook logins.

@ryanbr ryanbr requested a review from a team as a code owner March 13, 2021 02:02
@ryanbr
Copy link
Collaborator Author

ryanbr commented Mar 13, 2021

Current Brave release:
Brave-release-beta-faceb
Tested from the CI Build:
Brave-nightly-insta-faceb

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it to @pes10k to comment on the mapping. As far as chromium_src is concerned: ++

Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ryanbr ryanbr merged commit ac95bd4 into master Mar 17, 2021
@ryanbr ryanbr deleted the ffix-insta branch March 17, 2021 22:57
@ryanbr ryanbr added this to the 1.24.x - Nightly milestone Mar 19, 2021
@antgray80
Copy link

Hi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to login to Instagram
4 participants