Upgrade from Chromium 90 to Chromium 91. #8307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
mariospr
force-pushed
the
cr91
branch
10 times, most recently
from
6a4190c
to
22f4c59
Compare
mkarolin
changed the title
mkarolin
requested review from
iefremov,
samartnik,
simonhong,
tmancey and
a team
as code owners
mkarolin
commented
Apr 5, 2021
vendor/bat-native-ads/src/bat/ads/internal/account/confirmations/confirmations_state.cc
Show resolved
Hide resolved
Chromium change: https://chromium.googlesource.com/chromium/src/+/85285b04a02b765d7e4741f1e1588ae520c226d6 [LSC] Replace base::string16 with std::u16string in //[a-e]* This change replaces base::string16 with std::u16string in //[a-e]*. Reproduction steps: $ git grep -lw 'base::string16' [a-e]* | \ xargs sed -i 's/\bbase::string16\b/std::u16string/g' $ git cl format Bug: 1184339
Chromium change: https://chromium.googlesource.com/chromium/src/+/26eb7c14f9b19ae819bb7dc9a8d10e865a43fcc8 Android: Remove deps on chrome_java in c.b.search_engines The package c.b.search_engines is used by several components in core chrome. This CL removes its dependencies on chrome_java to pave the way for the other components to be modularized easily. Main dependencies handled are: - SettingsLauncherImpl: Injected from ToolbarManager. This is a stateless class so it can be shared/reused where the code can be simplified. - LocaleManager: Injects a runnable wrapping LocaleManager#setSearchEngineAutoSwitch(false) to SearchEngineAdapter Bug: 1171512
Also, removes unnecessary wrappring of base::Values into another base::Value when using them in SetKey.
Chromium change: https://chromium.googlesource.com/chromium/src/+/2cd13ac08252eedd9ac6490bfbf6cdfe249f7cc8 commit 2cd13ac08252eedd9ac6490bfbf6cdfe249f7cc8 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Mar 11 04:00:02 2021 +0000 Remove the padded button ink drop color. This can just be computed locally. Bug: none
Otherwise optimized builds will fail due to not being able to find the associated *.m.js files during the rollup process.
mkarolin
added
CI/run-network-audit
This applies upstream patch that fixes https://bugs.chromium.org/p/chromium/issues/detail?id=1198567 Issue 1198567: Headless browser freezes on Windows unless launched with '--disable-gpu' The fix is https://chromium-review.googlesource.com/c/chromium/src/+/2872065 and has not been merged into M91 yet. https://chromium.googlesource.com/chromium/src/+/641d54d756baff01484214b16b00b4935a8be657%5E%21/#F0 commit 641d54d756baff01484214b16b00b4935a8be657 author Alexis Hetu <sugoi@google.com> Revert using SwANGLE with kOverrideUseSoftwareGLForTests kOverrideUseSoftwareGLForTests is unfortunately not only used for tests and ends up being used for headless mode in the released version of Chrome. To avoid issues, we'll remove it for now, merge in beta and revert this CL afterwards, in order to give us enough time to write a proper fix for this. Bug: chromium:1060139
mkarolin
added
CI/skip-android
Chromium change: https://source.chromium.org/chromium/chromium/src/+/64da068f017ecd585a60f420f98270b3469397c1 commit 64da068f017ecd585a60f420f98270b3469397c1 Author: Daniel Cheng <dcheng@chromium.org> Date: Tue Mar 16 07:30:09 2021 +0000 [base] Disallow base::BindOnce() + base::Passed() everywhere. std::move() and base::Passed() mean the same thing for base::BindOnce(), so use the standard library idiom instead. Bug: 1180750
mkarolin
added a commit
that referenced
this pull request
May 18, 2021
Upgrade from Chromium 90 to Chromium 91.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#14848
Related PR: brave/brave-browser#14849
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: