Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show wallet promo panel when bitFlyer feature is disabled #8484

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Apr 8, 2021

Resolves brave/brave-browser#15194

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The "verify wallet" panel should not be displayed when the feature flag is not enabled:

  • Open browser with a clean profile for JP region, pointed to rewards staging.
  • Open the rewards panel.
  • Click "Start using Rewards".
  • Navigate through Rewards onboarding tour.
  • Verify that the "Verify wallet" panel is not displayed after the last tour step.

The "verify wallet" panel should be displayed when the feature flag is enabled:

  • Open browser with a clean profile for JP region, pointed to rewards staging.
  • Visit brave://flags and enable the bitFlyer feature flag, and restart the browser.
  • Open the rewards panel.
  • Click "Start using Rewards".
  • Navigate through Rewards onboarding tour.
  • Verify that the "Verify wallet" panel is displayed after the last tour step.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing
Copy link
Collaborator Author

CI Summary:

  • MacOS passed all tests, aborted on dist step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify wallet panel appears on Rewards onboarding tour
2 participants