Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Uphold sandbox URL #8492

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Apr 9, 2021

Resolves brave/brave-browser#14824

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Clean profile
  • Enable Rewards on staging
  • Claim grant
  • Verify Uphold wallet and confirm that this uses the correct URL (https://wallet-sandbox.uphold.com/...)
  • Verify that "Add funds" takes you to the correct page with the Brave card in the "To" field
  • Verify that "Withdraw funds" takes you to the correct page with the Brave card in the "From" field
  • Verify that visiting the Uphold dashboard works as expected

@emerick emerick requested a review from zenparsing April 9, 2021 19:51
@emerick emerick self-assigned this Apr 9, 2021
@emerick emerick merged commit 08a7d52 into master Apr 10, 2021
@emerick emerick deleted the rewards-update-uphold-staging-url branch April 10, 2021 00:12
@emerick emerick added this to the 1.25.x - Nightly milestone Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new Uphold sandbox URL
2 participants