Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Startpage icons #8656

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Update Startpage icons #8656

merged 1 commit into from
Apr 27, 2021

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Apr 27, 2021

Fixes brave/brave-browser#15515

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Android fresh install
  2. Go through Onboarding
  3. Verify new icon is used during onboarding (for Startpage)

@bsclifton bsclifton self-assigned this Apr 27, 2021
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya
Copy link
Contributor

deeppandya commented Apr 27, 2021

@bsclifton @jamesmudgett at some point, we should think about changing all search engine icons to vector drawable of possible. I can create a separate issue to track the change.

@bsclifton
Copy link
Member Author

@deeppandya sure, that would be great 😄

@deeppandya
Copy link
Contributor

Created an issue brave/brave-browser#15517

@deeppandya deeppandya closed this Apr 27, 2021
@bsclifton bsclifton reopened this Apr 27, 2021
@bsclifton bsclifton added this to the 1.25.x - Nightly milestone Apr 27, 2021
@bsclifton
Copy link
Member Author

Merging as errors are unrelated; this is just modifying an existing image (no tests around this)

@bsclifton
Copy link
Member Author

Whoops; turns out I had added an image (unintentionally) which broke things on Android build. Should have looked a bit closer at CI ☹️ If this PR is uplifted, please be sure to also uplift #8656

@bsclifton
Copy link
Member Author

Follow up - icons in this PR were too large; fixed with #8701 (so if this is uplifted, that would be needed too)

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.26.11 x64 Nightly build

  • Verified StartPage icon is similar to the other ones during onboarding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Startpage icon
4 participants