Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align container at the bottom #8732

Merged
merged 1 commit into from
May 6, 2021
Merged

Align container at the bottom #8732

merged 1 commit into from
May 6, 2021

Conversation

spylogsster
Copy link
Contributor

Resolves brave/brave-browser#15375

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open interstitial page, make the browser window size smaller and scroll
  • The container should stay at the bottom

@spylogsster spylogsster self-assigned this May 6, 2021
@spylogsster spylogsster requested a review from bbondy May 6, 2021 18:29
@bbondy bbondy requested review from Douglashdaniel and removed request for bbondy May 6, 2021 18:52
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spylogsster spylogsster merged commit ca6e247 into master May 6, 2021
@spylogsster spylogsster deleted the issue-15375 branch May 6, 2021 19:49
@spylogsster spylogsster added this to the 1.26.x - Nightly milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS interstitial page content and button gets clipped when the Developer Tools panel is open
2 participants