Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Rewards verbose logging flag on Android #8841

Merged
merged 1 commit into from
May 21, 2021

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#15924

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing requested a review from a team as a code owner May 18, 2021 13:54
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 0eb73da into master May 21, 2021
@zenparsing zenparsing deleted the ksmith-verbose-logging-android branch May 21, 2021 12:04
@zenparsing zenparsing added this to the 1.27.x - Nightly milestone May 21, 2021
brave-builds pushed a commit that referenced this pull request May 21, 2021
brave-builds pushed a commit that referenced this pull request May 21, 2021
@kjozwiak
Copy link
Member

Cases from https://github.com/brave/brave-core/pull/8598

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.27.10 Chromium: 91.0.4472.70

Error logging

  • disconnected the internet/network and attempted to create a wallet within a new profile
  • after ~1minute, enabled the network/internet and created a wallet
  • connected to a production uphold account
  • verified that only errors are appearing in brave://rewards-internals while #brave-rewards-verbose-logging is disabled
  • ensured that Refresh, Clear & Download are working as expected

Screenshot_20210521-230319_Brave - Nightly

Verbose logging

  • enabled #brave-rewards-verbose-logging via brave://flags
  • once enabled, created a new wallet
  • connected to my production Uphold account
  • verified there's more detailed logs present under brave://rewards-internals
  • ensured that Refresh, Clear & Download are working as expected
Example Example Example
Screenshot_20210521-230821_Brave - Nightly Screenshot_20210521-230805_Brave - Nightly Screenshot_20210521-230758_Brave - Nightly

Cases from https://github.com/brave/brave-core/pull/8767

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.27.10 Chromium: 91.0.4472.70
  • verified the STR outlined via Do not log request details for rewards external wallet session endpoints #8767 (comment)
  • ensured that clicking on Refresh correctly populates the empty text field with the log
  • ensured that clicking on Download log correctly initiates the download process/flow
  • ensured that *.uphold.com/oauth2/token didn't appear anywhere within the log after connecting to an Uphold account
    • also searched for oauth2 & oauth2/token within the log as a double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#brave-rewards-verbose-logging missing from Android - follow up to #15661
4 participants