Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#7398 - Resolves Delete and Cancel buttons not being shown when selecting items after searching history #8910

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

rahulsnkr
Copy link
Contributor

@rahulsnkr rahulsnkr commented May 23, 2021

Resolves brave/brave-browser#7398. Delete and cancel buttons now show up when selecting items after searching history. Attached a video of the feature working as expected.

search-history-brave.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@rahulsnkr
Copy link
Contributor Author

rahulsnkr commented May 24, 2021

Don't have permissions to request a review, so tagging instead - @petemill @karenkliu @bsclifton

Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rahulsnkr
Copy link
Contributor Author

rahulsnkr commented Jun 2, 2021

@karenkliu could you please merge the PR if everything looks good? I don't have the necessary permissions to do so.

@karenkliu
Copy link

We should wait on Pete's code review before merging.

@rahulsnkr
Copy link
Contributor Author

@petemill could you please review?

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great - matches the Chromium behavior exactly 😄 The search gets covered up by the X selected titlebar
image

@bsclifton
Copy link
Member

bsclifton commented Jun 18, 2021

@rahulsnkr sorry for the delay here - just wanted to give @petemill a chance to review 😄 He should be able to take a look soon! Thanks again for the patch (and for the quick fixup there!)

@bsclifton bsclifton merged commit 994390e into brave:master Jun 24, 2021
@bsclifton bsclifton added this to the 1.28.x - Nightly milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete button doesn't appear on brave://history when using the search box
3 participants