Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow default device name as a way to sync a device #915

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#2126

test plan:

  1. create a new sync chian
  2. leave device name empty
  3. should sync w/ default device name

darkdh
darkdh previously approved these changes Nov 15, 2018
@cezaraugusto cezaraugusto merged commit 0caf29e into master Nov 16, 2018
@cezaraugusto cezaraugusto deleted the cez-allow-sync-default-name branch November 16, 2018 01:54
cezaraugusto added a commit that referenced this pull request Nov 16, 2018
allow default device name as a way to sync a device
cezaraugusto added a commit that referenced this pull request Nov 16, 2018
allow default device name as a way to sync a device
@cezaraugusto
Copy link
Contributor Author

master 0caf29e
0.58.x 539e63b
0.57.x 0888636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create sync chain without entering a device name
4 participants