Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync device name should have restricted length #916

Closed
wants to merge 2 commits into from

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Nov 15, 2018

fix brave/brave-browser#2131

screen shot 2018-11-19 at 4 13 16 pm

test plan:

  • Create a new sync chain with a very long word
  • should display nicely

please note that the main "sync this device" option should be ignored since it will be removed in #913

@petemill
Copy link
Member

Can this be done with a class or style definition rather than mixing in the style specifics with the data?

Is this table a fixed width? Do we want this column to expand on larger windows?

Can you confirm that the element will have a title attribute so that the string will be shown on hover?

@cezaraugusto
Copy link
Contributor Author

@petemill added new components to fit table rows. also title added

table has fixed width per parent's size which is 840px. it does not expand to larger windows.

@bbondy
Copy link
Member

bbondy commented Dec 2, 2018

Ping on this since it's a couple weeks old.

@darkdh
Copy link
Member

darkdh commented Dec 3, 2018

I defer my review to @petemill and @cezaraugusto please do a rebase

@cezaraugusto
Copy link
Contributor Author

rebased. ping @petemill

@cezaraugusto
Copy link
Contributor Author

supersed by #1019

@cezaraugusto cezaraugusto deleted the cez-string-device-name branch December 12, 2018 20:01
@kjozwiak kjozwiak mentioned this pull request Dec 18, 2019
32 tasks
goodov added a commit that referenced this pull request Oct 17, 2022
Disable prerender test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync device name should have restricted length
4 participants