correctly delete fetchers #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Nov 22, 2018
| @@ -521,7 +521,11 @@ void RewardsServiceImpl::Shutdown() { | |||
| } | |||
| } | |||
|
|
|||
| for (const auto fetcher : fetchers_) { | |||
| delete fetcher.first; | |||
| } | |||
| fetchers_.clear(); | |||
There was a problem hiding this comment.
is this line needed then based on the fact that you delete all fetchers in for above?
There was a problem hiding this comment.
this clears out the pointers which point to invalid memory after they were deleted.
bbondy
approved these changes
Nov 22, 2018
|
Approved uplift to |
kjozwiak
added
uplift-approved/0.57.x-Beta
and removed
uplift-request/0.57.x-Beta
labels
|
0.57.x: ac1c4ee |
24 tasks
24 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#2213
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: