Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and upload silent and untagged Windows Omaha installers #974

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Create and upload silent and untagged Windows Omaha installers #974

merged 3 commits into from
Nov 28, 2018

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Nov 28, 2018

Fixes: brave/brave-browser#2210

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mbacchi mbacchi self-assigned this Nov 28, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Nov 28, 2018 •
edited
Loading

Approving for uplift to 0.57.x after deliberating with @srirambv & @rebron 👍

@mbacchi before tagging issues as uplift-request/0.57.x-Beta, they should usually:

  • have passed review, closed and merged into master
  • merged into dev

Once merged into dev, request for approval 👍

mihaiplesa
mihaiplesa previously approved these changes Nov 28, 2018
View reviewed changes
Copy link
Collaborator

@mihaiplesa mihaiplesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mihaiplesa mihaiplesa requested review from mihaiplesa and removed request for simonhong November 28, 2018 15:32
mihaiplesa
mihaiplesa approved these changes Nov 28, 2018
View reviewed changes
Copy link
Collaborator

@mihaiplesa mihaiplesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge

@mbacchi mbacchi merged commit e3491ee into master Nov 28, 2018
@mbacchi
Copy link
Contributor Author

mbacchi commented Nov 28, 2018

Thanks @kjozwiak I'll remember that process for the next time. Appreciate your explanation.

@mbacchi mbacchi deleted the issue_2210 branch November 28, 2018 15:39
mbacchi added a commit that referenced this pull request Nov 28, 2018
@mbacchi
Merge pull request #974 from brave/issue_2210
e9088ff 
Create and upload silent and untagged Windows Omaha installers
mbacchi added a commit that referenced this pull request Nov 28, 2018
@mbacchi
Merge pull request #974 from brave/issue_2210
d59f4e4 
Create and upload silent and untagged Windows Omaha installers

Fix merge conflict in package.json:

Conflicts:
	package.json
@mbacchi
Copy link
Contributor Author

mbacchi commented Nov 28, 2018

master: e3491ee
0.58.x: e9088ff
0.57.x: d59f4e4

@bbondy
Copy link
Member

bbondy commented Nov 28, 2018

adding merged label.

@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
@kjozwiak kjozwiak mentioned this pull request Mar 5, 2020
Merged
32 tasks
@LaurenWags LaurenWags mentioned this pull request Mar 10, 2020
Merged
32 tasks
@btlechowski btlechowski mentioned this pull request Mar 12, 2020
Merged
32 tasks
@LaurenWags LaurenWags mentioned this pull request Mar 12, 2020
Merged
32 tasks
@kjozwiak kjozwiak mentioned this pull request Mar 13, 2020
Merged
32 tasks
This was referenced Mar 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa mihaiplesa approved these changes

Assignees

@mbacchi mbacchi

Labels
development environment
Projects
None yet
Milestone
0.57.x - Release
Development

Successfully merging this pull request may close these issues.

Create and automatically publish silent installers for Brave-Core (Windows)
4 participants
@mbacchi @kjozwiak @bbondy @mihaiplesa