From 0aaeab13a93f28c7252b8eaf6b3a5e7200413913 Mon Sep 17 00:00:00 2001 From: Brandon-T Date: Fri, 26 Jan 2024 12:49:00 -0500 Subject: [PATCH] Fix #8705: Add display for version info (#8706) - Add display for version info --- .../Frontend/Settings/SettingsViewController.swift | 11 +++++++++++ Sources/BraveStrings/BraveStrings.swift | 1 + 2 files changed, 12 insertions(+) diff --git a/Sources/Brave/Frontend/Settings/SettingsViewController.swift b/Sources/Brave/Frontend/Settings/SettingsViewController.swift index 8b1275eccbe..5da5abee133 100644 --- a/Sources/Brave/Frontend/Settings/SettingsViewController.swift +++ b/Sources/Brave/Frontend/Settings/SettingsViewController.swift @@ -744,9 +744,20 @@ class SettingsViewController: TableViewController { UIPasteboard.general.setSecureString(AppStorageDebugComposer.compose(), expirationDate: Date().addingTimeInterval(2.minutes)) } + + let viewMoreDetails = UIAlertAction(title: Strings.viewAllVersionInfo, style: .default) { [unowned self, weak actionSheet] _ in + let versionController = ChromeWebViewController(privateBrowsing: false).then { + $0.loadURL("brave://version/?show-variations-cmd") + } + + actionSheet?.dismiss(animated: true, completion: { + self.present(versionController, animated: true) + }) + } actionSheet.addAction(copyDebugInfoAction) actionSheet.addAction(copyAppInfoAction) + actionSheet.addAction(viewMoreDetails) actionSheet.addAction(UIAlertAction(title: Strings.cancelButtonTitle, style: .cancel, handler: nil)) self.navigationController?.present(actionSheet, animated: true, completion: nil) }, cellClass: MultilineValue1Cell.self), diff --git a/Sources/BraveStrings/BraveStrings.swift b/Sources/BraveStrings/BraveStrings.swift index 88cd7f3b13c..6655294166f 100644 --- a/Sources/BraveStrings/BraveStrings.swift +++ b/Sources/BraveStrings/BraveStrings.swift @@ -1167,6 +1167,7 @@ extension Strings { NSLocalizedString("copyAppSizeInfoToClipboard", tableName: "BraveShared", bundle: .module, value: "Copy app size info to clipboard.", comment: "Copy app info to clipboard action sheet action.") + public static let viewAllVersionInfo = NSLocalizedString("copyAppSizeInfoToClipboard", tableName: "BraveShared", bundle: .module, value: "View all version info.", comment: "View all version info action sheet action.") public static let blockThirdPartyCookies = NSLocalizedString("Block3rdPartyCookies", tableName: "BraveShared", bundle: .module, value: "Block 3rd party cookies", comment: "cookie settings option") public static let blockAllCookies = NSLocalizedString("BlockAllCookies", tableName: "BraveShared", bundle: .module, value: "Block all Cookies", comment: "Title for setting to block all website cookies.") public static let blockAllCookiesAction = NSLocalizedString("BlockAllCookiesAction", tableName: "BraveShared", bundle: .module, value: "Block All", comment: "block all cookies settings action title")