Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6562: Actually record p3a answer when cookie list is toggled #6564

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

kylehickinson
Copy link
Collaborator

Summary of Changes

This pull request fixes #6562

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.46 milestone Dec 6, 2022
@kylehickinson kylehickinson requested a review from a team December 6, 2022 16:27
@kylehickinson kylehickinson merged commit 5611ad2 into development Dec 6, 2022
@kylehickinson kylehickinson deleted the p3a-cookie-list-enabled branch December 6, 2022 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up of #6547 - Brave.Shields.CookieListEnabled response is not sent to local state file
2 participants