Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8576: Address bar blank before website starts loading #8577

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix #8576: Address bar blank before website starts loading #8577

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
540bc0e
Update the url bar if it is invoked from NTP directly using the webv…
soner-yuksel Dec 18, 2023
473661b
url shown cant be local url
soner-yuksel Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Sources/Brave/Frontend/Browser/BrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1755,6 +1755,14 @@ public class BrowserViewController: UIViewController {
navigateInTab(tab: tab)
} else {
updateURLBar()
// If navigation will start from NTP, tab display url will be nil until
// didCommit is called and it will cause url bar be empty in that period
// To fix this when tab display url is empty, webview url is used
if tab.url?.displayURL == nil {
if let url = webView.url, !url.isLocal, !InternalURL.isValid(url: url) {
updateToolbarCurrentURL(url.displayURL)
}
}
}

// Rewards reporting
Expand Down