Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Unverified publishers in panel can now have status refreshed #438

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Mar 28, 2019

Addresses brave/brave-browser#3339

Changes

Added 'Check again...' link to check for publisher's verified status

Test plan

Open unverified wallet panel, verify 'Check again...' link
image

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@ryanml
Copy link
Contributor

ryanml commented Mar 28, 2019

@jasonrsadler can you generate a now.sh link for this feature? Like https://brave-ui-m1yk2rzha.now.sh/

@jasonrsadler jasonrsadler force-pushed the pub-refresh branch 3 times, most recently from 11ffffd to c2b67d3 Compare April 3, 2019 14:15
Fixing column widths

Adding function for link. Storybook changes.

Make method optional

Adding flex attribute to a element

Align last flex item to right for check link

Replace removed margin

Update z-index for link

Adding loading icon

Correcting refreshed check

Add missing attribute for prop

Removed unneeded prop

returning prop needed to show spinner

Updates spec for month rollover
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks fine to me

@jasonrsadler jasonrsadler merged commit 7a08a8f into master Apr 3, 2019
@jasonrsadler jasonrsadler deleted the pub-refresh branch April 3, 2019 19:42
jasonrsadler pushed a commit that referenced this pull request Apr 17, 2019
Unverified publishers in panel can now have status refreshed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants