Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

New Tab Page: removed, now part of brave-core #511

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Conversation

petemill
Copy link
Member

@petemill petemill commented Jul 8, 2019

Changes

Removes New Tab Page feature, which was moved in to brave-core with brave/brave-core#2857

Test plan

Automated

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR: https://brave-ui-pgprhdmnb.now.sh
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@petemill petemill self-assigned this Jul 8, 2019
@imptrx
Copy link
Contributor

imptrx commented Jul 8, 2019

Since all the code in features/newTab/default/widget was already moved to brave-core, I believe we can remove that leftover code as well. LGTM otherwise 👍

Copy link
Contributor

@rossmoody rossmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be gone!

@cezaraugusto cezaraugusto merged commit de2511e into master Jul 10, 2019
@cezaraugusto cezaraugusto deleted the remove-ntp branch July 10, 2019 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants