From 26afbd557d0ba6b005142264a86f00404161932b Mon Sep 17 00:00:00 2001 From: "Brian R. Bondy" Date: Mon, 15 May 2017 14:02:39 -0400 Subject: [PATCH] Remove old copy hack for macOS packaged builds Recently we've been having an intermittent copy problem on macOS again that we haven't seen for a year. To attempt to fix this we're going to revert an old hack that @diracdeltas did which held us until now Fix #8876 --- app/localShortcuts.js | 9 --------- js/constants/messages.js | 1 - js/stores/windowStore.js | 2 +- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/app/localShortcuts.js b/app/localShortcuts.js index 1255f8e77b2..2f12a0fa329 100644 --- a/app/localShortcuts.js +++ b/app/localShortcuts.js @@ -45,15 +45,6 @@ module.exports.register = (win) => { simpleWebContentEvents.push( ['Cmd+Alt+U', messages.SHORTCUT_ACTIVE_FRAME_VIEW_SOURCE] ) - - if (process.env.NODE_ENV !== 'development') { - // We're in Darwin and release or test mode... - // We disable for development mode because Browser level dev tools copy doesn't work. - // Workaround for #1060 - simpleWebContentEvents.push( - ['Cmd+C', messages.SHORTCUT_ACTIVE_FRAME_COPY] - ) - } } // Tab ordering shortcuts diff --git a/js/constants/messages.js b/js/constants/messages.js index e8eb61d9984..6df5cd1454f 100644 --- a/js/constants/messages.js +++ b/js/constants/messages.js @@ -26,7 +26,6 @@ const messages = { SHORTCUT_ACTIVE_FRAME_FORWARD: _, SHORTCUT_ACTIVE_FRAME_BOOKMARK: _, SHORTCUT_ACTIVE_FRAME_REMOVE_BOOKMARK: _, - SHORTCUT_ACTIVE_FRAME_COPY: _, SHORTCUT_ACTIVE_FRAME_FIND_NEXT: _, SHORTCUT_ACTIVE_FRAME_FIND_PREV: _, // Frame management shortcuts diff --git a/js/stores/windowStore.js b/js/stores/windowStore.js index 24521df0343..654f740d9a0 100644 --- a/js/stores/windowStore.js +++ b/js/stores/windowStore.js @@ -789,7 +789,7 @@ ipc.on(messages.SHORTCUT_OPEN_CLEAR_BROWSING_DATA_PANEL, (e) => { }) }) -const frameShortcuts = ['stop', 'reload', 'zoom-in', 'zoom-out', 'zoom-reset', 'toggle-dev-tools', 'clean-reload', 'view-source', 'mute', 'save', 'print', 'show-findbar', 'copy', 'find-next', 'find-prev'] +const frameShortcuts = ['stop', 'reload', 'zoom-in', 'zoom-out', 'zoom-reset', 'toggle-dev-tools', 'clean-reload', 'view-source', 'mute', 'save', 'print', 'show-findbar', 'find-next', 'find-prev'] frameShortcuts.forEach((shortcut) => { // Listen for actions on the active frame ipc.on(`shortcut-active-frame-${shortcut}`, (e, args) => {