Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Whitelist embedded tweets and fb images
Browse files Browse the repository at this point in the history 
Fix #1208
Fix #2014

Auditors: @bbondy
  • Loading branch information
@diracdeltas
diracdeltas committed Jun 1, 2016
1 parent 2277ff0 commit 6edf567
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/trackingProtection.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ let trackingProtection
let cachedFirstParty = new LRUCache(50)

// Temporary whitelist until we find a better solution
const whitelistHosts = ['connect.facebook.net', 'connect.facebook.com', 'staticxx.facebook.com', 'www.facebook.com', 'scontent.xx.fbcdn.net', 'pbs.twimg.com']
const whitelistHosts = ['connect.facebook.net', 'connect.facebook.com', 'staticxx.facebook.com', 'www.facebook.com', 'scontent.xx.fbcdn.net', 'pbs.twimg.com', 'scontent-sjc2-1.xx.fbcdn.net', 'platform.twitter.com', 'syndication.twitter.com']

This comment has been minimized.

Sign in to view

Copy link
@bbondy

bbondy Jun 1, 2016

Member

For now it's pretty obvious what they are for, but might be good to add a comment for each explaining what it is for.

const startTrackingProtection = (wnd) => {
Filtering.registerBeforeRequestFilteringCB((details) => {
Expand Down

2 comments on commit 6edf567

@bbondy
Copy link
Member

@bbondy bbondy commented on 6edf567 Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for now, @SergeyZhukovsky @garvankeeley pls sync.

@garvankeeley
Copy link
Contributor

@garvankeeley garvankeeley commented on 6edf567 Jun 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS: https://github.com/brave/browser-ios/commit/db512f0c0e75c524ca08cd3a1fc51e7c0b16676a

Please sign in to comment.