filter out non-http(s) urls in https everywhere

There is no need to check redirect loops unless a URL is http or https. Auditors: @bbondy Test Plan: n/a
brave · Oct 26, 2016 · 957b748 · 957b748 · bbondy · Oct 28, 2016
1 parent ee5cb60
commit 957b748
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/app/httpsEverywhere.js b/app/httpsEverywhere.js
@@ -142,6 +142,10 @@ function onBeforeRedirect (details) {
  if (!mainFrameUrl || !Filtering.isResourceEnabled(module.exports.resourceName, mainFrameUrl)) {
  return
  }
+ // Ignore URLs that are not HTTP
+ if (!['http:', 'https:'].includes(urlParse(details.url).protocol)) {
+ return
+ }
 
  var canonicalUrl = canonicalizeUrl(details.url)