remove event listener on unmount and don't bind to avoid memory leak

auditors: @bbondy
brave · Sep 16, 2016 · ad43443 · ad43443 · bbondy · Sep 18, 2016
1 parent 6802928
commit ad43443
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/js/components/contextMenu.js b/js/components/contextMenu.js
@@ -11,7 +11,10 @@ const KeyCodes = require('../constants/keyCodes')
 
 class ContextMenuItem extends ImmutableComponent {
  componentDidMount () {
- window.addEventListener('keydown', this.onKeyDown.bind(this))
+ window.addEventListener('keydown', this.onKeyDown)
+ }
+ componentWillUnmount () {
+ window.removeEventListener('keydown', this.onKeyDown)
  }
  onKeyDown (e) {
  if (e.keyCode === KeyCodes.ESC || e.keyCode === KeyCodes.TAB) {