Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

appStore calls diff on the state without first checking to see if there are changes #10195

Closed
bridiver opened this issue Jul 28, 2017 · 2 comments
Closed

appStore calls diff on the state without first checking to see if there are changes #10195

bridiver opened this issue Jul 28, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@bridiver
Copy link
Collaborator

bridiver commented Jul 28, 2017 •
edited by luixxiul
Loading

Test plan

#10498 (comment)

diff is a relatively expensive operation on the state and we should short-circuit emitChanges if lastEmittedState === appState
@bridiver bridiver added the perf label Jul 28, 2017
@NejcZdovc NejcZdovc added the hackathon Legacy label for a hackaton. label Jul 29, 2017
@NejcZdovc NejcZdovc self-assigned this Aug 15, 2017
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Aug 15, 2017
@NejcZdovc
Copy link
Contributor

@bbondy I putted this into 0.21, but please move it into earlier branches if needed.

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 15, 2017
@NejcZdovc
First quick check if lastEmittedState and appState are different
a179743 
Resolves brave#10195

Auditors: @bridiver @bbondy

Test Plan:
- open two windows
- add bookmark in one
- bookmark should appear in both bookmark toolbars
@NejcZdovc NejcZdovc mentioned this issue Aug 15, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Beta Channel), 0.21.x (Nightly Channel) Aug 15, 2017
NejcZdovc added a commit that referenced this issue Aug 15, 2017
@NejcZdovc
Merge pull request #10498 from NejcZdovc/hotfix/#10195-emittedState
5ed280b 
First quick check if lastEmittedState and appState are different
NejcZdovc added a commit that referenced this issue Aug 15, 2017
@NejcZdovc
First quick check if lastEmittedState and appState are different
db4f45d 
Resolves #10195

Auditors: @bridiver @bbondy

Test Plan:
- open two windows
- add bookmark in one
- bookmark should appear in both bookmark toolbars
NejcZdovc added a commit that referenced this issue Aug 15, 2017
@NejcZdovc
First quick check if lastEmittedState and appState are different
9f529f2 
Resolves #10195

Auditors: @bridiver @bbondy

Test Plan:
- open two windows
- add bookmark in one
- bookmark should appear in both bookmark toolbars
NejcZdovc added a commit that referenced this issue Aug 15, 2017
@NejcZdovc
First quick check if lastEmittedState and appState are different
69ec750 
Resolves #10195

Auditors: @bridiver @bbondy

Test Plan:
- open two windows
- add bookmark in one
- bookmark should appear in both bookmark toolbars
@luixxiul
Copy link
Contributor

added release-notes/include since every improvement of perf is worth mentioning on the release note

dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
First quick check if lastEmittedState and appState are different
69fba5e 
Resolves brave#10195

Auditors: @bridiver @bbondy

Test Plan:
- open two windows
- add bookmark in one
- bookmark should appear in both bookmark toolbars
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Sep 25, 2017
Closed
@srirambv srirambv mentioned this issue Sep 26, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@bridiver @luixxiul @NejcZdovc @srirambv @LaurenWags