Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

action buttons on about pages not aligned consistently #10465

Closed
luixxiul opened this issue Aug 14, 2017 · 0 comments · Fixed by #11202
Closed

action buttons on about pages not aligned consistently #10465

luixxiul opened this issue Aug 14, 2017 · 0 comments · Fixed by #11202
Assignees
@luixxiul
Labels
bug design A design change, especially one which needs input from the design team. feature/about-pages QA/test-plan-specified release-notes/exclude

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 14, 2017 •
edited
Loading

Test plan

#11202 (comment)

Describe the issue you encountered: action buttons on about pages are not aligned consistently.

On about:bookmarks
screenshot 2017-08-14 10 42 47

On about:history
screenshot 2017-08-14 10 42 42

(Also the search icon is not placed on the same place of the input field. It will be fixed with another PR which I'm preparing.)

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. Open about:history
    2. Open about:bookmarks

  • Actual result: See above

  • Expected result: the both buttons should appear left OR right of the input field

  • Any related issues:
@luixxiul luixxiul added bug design A design change, especially one which needs input from the design team. feature/about-pages labels Aug 14, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 14, 2017
@luixxiul luixxiul self-assigned this Aug 14, 2017
@luixxiul luixxiul mentioned this issue Aug 14, 2017
Closed
8 tasks
@luixxiul luixxiul removed this from the 0.21.x (Nightly Channel) milestone Sep 7, 2017
@luixxiul luixxiul added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed priority/low (deprecated) labels Sep 13, 2017
@luixxiul luixxiul mentioned this issue Sep 24, 2017
Closed
8 tasks
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 24, 2017
@ghost ghost removed this from the 0.21.x (Nightly Channel) milestone Sep 26, 2017
@luixxiul luixxiul mentioned this issue Sep 28, 2017
Merged
8 tasks
@luixxiul luixxiul removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 28, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Add 'fitContent' props to browserButton
e2789e8 
Fixes brave#11201

Only BrowserButton with 'fitContent' props are forced to have the min-width:fit-content. This change is required to apply display:flex to headerActions, as it refers width instead of min-width, even though actual min-width is larger than actual width of the buttons.

- Align header items on about:history (fixes brave#10465)
- Polish .searchInput on about:bookmarks and about:history (addresses brave#10898 and brave#10899)

Auditors: @cezaraugusto

Test Plan:
1. Open about:history
2. Open about:bookmarks
3. Make sure the header items are not wrapped

Test Plan 2:
1. Open https://expired.badssl.com/
2. Minimize the window's width
3. Make sure the buttons' text do not overflow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
bug design A design change, especially one which needs input from the design team. feature/about-pages QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'fitContent' props to browserButton
2 participants
@alexwykoff @luixxiul