Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor js/about/history.js with Aphrodite #10899

Closed
luixxiul opened this issue Sep 11, 2017 · 0 comments
Closed

Refactor js/about/history.js with Aphrodite #10899

luixxiul opened this issue Sep 11, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Refactor js/about/history.js with Aphrodite

@luixxiul luixxiul self-assigned this Sep 11, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Fixes brave#11201

Only BrowserButton with 'fitContent' props are forced to have the min-width:fit-content. This change is required to apply display:flex to headerActions, as it refers width instead of min-width, even though actual min-width is larger than actual width of the buttons.

- Align header items on about:history (fixes brave#10465)
- Polish .searchInput on about:bookmarks and about:history (addresses brave#10898 and brave#10899)

Auditors: @cezaraugusto

Test Plan:
1. Open about:history
2. Open about:bookmarks
3. Make sure the header items are not wrapped

Test Plan 2:
1. Open https://expired.badssl.com/
2. Minimize the window's width
3. Make sure the buttons' text do not overflow
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants