Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave Processes Not Auto Killing After Brave is Closed #1097

Closed
weems opened this issue Mar 16, 2016 · 10 comments
Closed

Brave Processes Not Auto Killing After Brave is Closed #1097

weems opened this issue Mar 16, 2016 · 10 comments

Comments

@weems
Copy link

weems commented Mar 16, 2016

Brave Processes should be killed after closing to cleanly exit. Important for both Security and Performance. Particularly for Users on Windows who are affected by #1096

@bbondy
Copy link
Member

bbondy commented Mar 17, 2016

Brave process shoudl be closed in the actual release of Brave (which matches RC 7). Could you try the latest and confirm exact STR?

@bbondy
Copy link
Member

bbondy commented Mar 17, 2016

This one is more exact of what I see:
#1119

@weems
Copy link
Author

weems commented Mar 18, 2016

I installed 0.8.1 Beta. After running install and launching Brave I closed the window. The processes were still running afterwards.

@onmyouji
Copy link

I also experienced the same thing on Windows 7.

@bbondy
Copy link
Member

bbondy commented Mar 18, 2016

@weems please forget about the pre-release builds of 0.8.1, they had an issue for this and it was fixed. Does the current and live release of 0.8.1 reproduce and if so what are the exact steps?

@bbondy
Copy link
Member

bbondy commented Mar 18, 2016

For the pre-release if you have processes left over just kill them with the task manager to test fresh.

@weems
Copy link
Author

weems commented Mar 19, 2016

@bbondy I see you have a pre-release fix, but in 0.8.1 Production processes are not being killed. STR is basically close Brave and use 'taskman' to see if processes remain. and currently they do.

@bbondy
Copy link
Member

bbondy commented Mar 19, 2016

Confused because in Slack around the same time you said the opposite:

confirmed processes are closed after Brave closes in the newest 0.8.1 dev channel on Win7 x64

@weems
Copy link
Author

weems commented Mar 19, 2016

@bbondy at that time I had not yet updated to the pre-release version with the fix for processes closing

@bbondy
Copy link
Member

bbondy commented Mar 19, 2016

OK thanks, closing this.

@bbondy bbondy closed this as completed Mar 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants