Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Edit "Where to put my code" on docs/style.md about how to refer the style files #11540

Closed
luixxiul opened this issue Oct 15, 2017 · 0 comments
Closed
Labels
documentation ✍ needs-discussion A suggestion that lacks agreement from the team. stale

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 15, 2017

Description

Edit "Where to put my code" on docs/style.md about how to refer the style files.

See: f0c77b7#r144715080 on app/renderer/components/tabs/content/closeTabIcon.js

// Styles
const {theme} = require('../../styles/theme')
-const {spacing, zindex} = require('../../styles/global')
-const {opacityIncreaseKeyframes} = require('../../styles/animations')
+const globalStyles = require('../../styles/global')

Before introducing a new way of referring the styles, let's edit docs/style.md#where-to-put-my-code to explain to do so (and why we do so).

@cezaraugusto: I am not quite sure yet why this is needed, but maybe for readability (and slight performance improvement)?

Additional Information

@luixxiul luixxiul added documentation ✍ refactoring/aphrodite needs-discussion A suggestion that lacks agreement from the team. labels Oct 15, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation ✍ needs-discussion A suggestion that lacks agreement from the team. stale
Projects
None yet
Development

No branches or pull requests

2 participants