Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Beta build doesn't launch from console #11824

Closed
srirambv opened this issue Nov 7, 2017 · 4 comments · Fixed by #11838
Closed

Beta build doesn't launch from console #11824

srirambv opened this issue Nov 7, 2017 · 4 comments · Fixed by #11838

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 7, 2017

Test plan

see #11838

Description

Beta build doesn't launch from console

Steps to Reproduce

  1. Install 0.20.6
  2. Close the browser
  3. Launch from console, doesn't launch, same result as Brave Beta/Developer fails to launch #11791, console shows error

Actual result:

$ An uncaught exception occurred in the main process Uncaught Exception:
Error: Cannot find module './updater'
    at Module._resolveFilename (module.js:470:15)
    at Function.Module._resolveFilename (C:\Users\Sriram BV\AppData\Local\BraveBeta\app-0.20.6\resources\electron.asar\common\reset-search-paths.js:41:12)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at C:\Users\Sriram BV\AppData\Local\BraveBeta\app-0.20.6\resources\app.asar\app\index.js:53:17
    at Object.<anonymous> (C:\Users\Sriram BV\AppData\Local\BraveBeta\app-0.20.6\resources\app.asar\app\index.js:356:2)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
[1107/145650.716:ERROR:process_info.cc(632)] range at 0x9e864b0600000000, size 0x1f3 fully unreadable
[1107/145650.716:ERROR:process_info.cc(632)] range at 0x9e864b2600000000, size 0x1f3 fully unreadable
[1107/145650.716:ERROR:process_info.cc(632)] range at 0x0, size 0x1f3 fully unreadable
Waiting 60 seconds for process to load

Expected result:
Browser should launch from console

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.6
V8 6.2.414.36
rev 18f7d1e
Muon 4.5.14
OS Release 10.0.15063
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 62.0.3202.75

Reproducible on current live release:
N/A

Additional Information

@srirambv srirambv added 0.20.x issue first seen in 0.20.x bug OS/Windows labels Nov 7, 2017
@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Nov 7, 2017
@darkdh
Copy link
Member

darkdh commented Nov 7, 2017

If you wanna launch non release Brave from console, make sure you specify
user-data-dir-name switch.
See shortcut on start menu or desktop
C:\Users\darkdh\AppData\Local\BraveBeta\BraveBeta.exe -a "--user-data-dir-name=brave-beta

@darkdh darkdh closed this as completed Nov 7, 2017
@darkdh darkdh removed this from the 0.20.x (Beta Channel) milestone Nov 7, 2017
@darkdh
Copy link
Member

darkdh commented Nov 7, 2017

sorry, I take it back. I just recalled we have automatically adding switch functionality

app.relaunch({args: [userDataDirSwitch, '--relaunch']})
} else {
app.relaunch({args: process.argv.slice(1) + [userDataDirSwitch, '--relaunch']})

@darkdh darkdh reopened this Nov 7, 2017
@darkdh darkdh added this to the 0.20.x (Beta Channel) milestone Nov 7, 2017
darkdh added a commit that referenced this issue Nov 8, 2017
fix #11821, #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir
@darkdh darkdh mentioned this issue Nov 8, 2017
8 tasks
darkdh added a commit that referenced this issue Nov 10, 2017
fix #11821, #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir
darkdh added a commit that referenced this issue Nov 10, 2017
fix #11821
fix #11824

Auditors: @bsclifton

Test Plan:
a. CHANNEL=beta npm start shouldn't relaunch

b. CHANNEL=beta npm build-package
b-1. ./BraveBeta-win32-x64/BraveBeta.exe should relaunch and use `brave-beta` as user dir
b-2 CHANNEL=beta npm build-installer
b-3 Install Brave by dist/x64/BraveBeta-Setup-x64.exe
b-4 After installation, the first time launch should relaunch and use `brave-beta` as user dir
@kjozwiak
Copy link
Member

Using 0.20.9, ensured that the following two commands launched brave within the terminal under Ubuntu 17.10 x64:

  • brave-beta --user-data-dir-name=brave-beta
  • brave-beta

@kjozwiak
Copy link
Member

kjozwiak commented Dec 21, 2017

Even though is marked as "Windows", I double checked and ensured that you can launch brave from all three platforms via the terminal/console.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants