Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Moving nested bookmarks folder to root folder is not shown on toolbar #12052

Closed
srirambv opened this issue Nov 21, 2017 · 5 comments
Closed

Moving nested bookmarks folder to root folder is not shown on toolbar #12052

srirambv opened this issue Nov 21, 2017 · 5 comments
Assignees
@NejcZdovc
Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

Description

Moving nested bookmarks folder to root folder is not shown on toolbar

Steps to Reproduce

  1. Clean install 0.20.7
  2. Import 5k bookmark with nested folders
  3. Move nested folder to root folder, all nested folders and bookmarks are lost
  4. Move individual bookmark to root folder, shows up on toolbar

Actual result:
bookmarks

Expected result:
Should show bookmark nested folder on toolbar when moved to root folder

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.7
V8 6.2.414.42
rev a2ba3e8
Muon 4.5.16
OS Release 10.0.15063
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 62.0.3202.94

Reproducible on current live release:
No

Additional Information
@srirambv srirambv added this to the Prioritized Backlog milestone Nov 21, 2017
@bsclifton bsclifton modified the milestones: Prioritized Backlog, Triage Backlog Nov 21, 2017
@cezaraugusto cezaraugusto added priority/P3 Major loss of function. priority/P2 Crashes. Loss of data. Severe memory leak. and removed priority/P3 Major loss of function. labels Nov 21, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@luixxiul
Copy link
Contributor

Should its milestone not be escalated to 0.20.x as it is a regression?

@srirambv srirambv mentioned this issue Dec 20, 2017
Merged
@NejcZdovc NejcZdovc self-assigned this Jan 5, 2018
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.20.x (Beta Channel) Jan 5, 2018
@NejcZdovc
Copy link
Contributor

@srirambv can you please check if this issue is fixed with this PR #12517

@srirambv
Copy link
Collaborator Author

srirambv commented Jan 5, 2018

Will do

@srirambv
Copy link
Collaborator Author

srirambv commented Jan 5, 2018

Tested the PR works fine
12517

@cezaraugusto
Copy link
Contributor

thanks @srirambv just landed #12517 I'm closing this

@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
@srirambv srirambv mentioned this issue Jan 24, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
7 participants
@kjozwiak @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv @LaurenWags