Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

moving bookmark folder from Bookmarks Toolbar to Other Bookmarks still displays on toolbar #12484

Closed
LaurenWags opened this issue Jan 3, 2018 · 1 comment

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2018

Test plan

#12589 (comment)

  1. Open Bookmarks Manager
  2. Add a folder under 'Bookmarks Toolbar'
  3. Verify folder displays on the Bookmarks Toolbar.
  4. Drag and drop the folder from step 2 to 'Other Bookmarks'
  5. Folder should move

Description

Using the Bookmark Manager, if you move a folder from Bookmarks Toolbar to Other Bookmarks, the folder still displays on the toolbar until you add another folder.

Steps to Reproduce

  1. Open Bookmarks Manager
  2. Add a folder under 'Bookmarks Toolbar'
  3. Verify folder displays on the Bookmarks Toolbar.
  4. Drag and drop the folder from step 2 to 'Other Bookmarks'

Actual result:
Folder still displays on the Bookmarks Toolbar:
bookmarktoolbar

Expected result:
Bookmark Folder should not display on the Toolbar.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.14
V8 | 6.3.292.48
rev | 5d75826
Muon | 4.5.33

Reproducible on current live release:
No, not reproducible due to #12378

Additional Information

Found by @kjozwiak and reproduced on MacOS

@LaurenWags LaurenWags added 0.20.x issue first seen in 0.20.x bug feature/bookmarks labels Jan 3, 2018
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 4, 2018
Resolves brave#12484

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Jan 4, 2018
bsclifton added a commit that referenced this issue Jan 4, 2018
bsclifton added a commit that referenced this issue Jan 4, 2018
@LaurenWags
Copy link
Member Author

Able to reproduce with these steps (reproduced on Win by @srirambv )
Have a folder on Bookmarks Toolbar
Right click on the folder, Edit Folder
Change location to be 'Other Bookmarks' instead of 'Bookmarks Toolbar', click Done.
Folder continues to display on Bookmarks Toolbar.

@LaurenWags LaurenWags reopened this Jan 9, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 10, 2018
bsclifton added a commit that referenced this issue Jan 12, 2018
Fixes edit flow for bookmarks and folders
bsclifton added a commit that referenced this issue Jan 12, 2018
Fixes edit flow for bookmarks and folders
bsclifton added a commit that referenced this issue Jan 12, 2018
Fixes edit flow for bookmarks and folders
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.