whitelist script signatures

[bridiver]

Test Plan

1. Go to adops.com w/ shields on
2. Ensure the site is usable
3. Go to shields hit ads and trackers blocked
4. List of blocked ads should not include the first-party domain

---

I recently went to adops.com and the site was basically unusable because they are on the blocking list. I don't really see any reason why we should be blocking jquery and other scripts that are not ad related. Not sure if a whitelist is the answer, but maybe consider the referrer url (when not in an iframe) because these are 1st-party scripts in this context.

[diracdeltas]

this is a bug - TP/AB should not be blocking first party resources in the first place

[diracdeltas]

need @bbondy input. i would have expected adblock.matches(details.url, mapFilterType[details.resourceType], firstPartyUrl.host) to return false when details.url is first-party to firstPartyUrl.host. apparently this is not the case. should this be fixed in the ABP module or is it a check we need to add to app/adBlock.js?

[bbondy]

I thought we already had this check but apparently not. We should just do an extra check to make sure the details.url host is different from the firstPartyUrl.host in app/adBlock.js.

[bbondy]

re-opening, I think a rule like this will fix: @@||adops.com$~third-party

[bbondy]

mostly fixed by the filtering rule committed above, but some things are still getting blocked that shouldn't (logo). I think it's a bug in the ad block library and could be a more generalized problem so blocking on this since the first party filtering change first lands in 0.20.x too.

[bbondy]

Never mind, I just tested with combined data file and it's working. I was testing before with custom adblock rule exception which runs in an independent instance

[cezaraugusto]

heads-up I added a basic test plan please add more checks in case mine is incomplete. Thanks