'when closing an active tab' setting does not work

[LaurenWags]

Description

'When closing an active tab' setting is not respected. If you have 'Select its parent tab' (default) or 'Select the last viewed tab' as the setting, the next tab is selected. See test cases from #12193 (comment)

Steps to Reproduce

See test cases from #12193 (comment) - I specifically used the Parent tab and Next tab test cases but all should be checked.

Actual result:
Next tab is always selected, doesn't matter if you have parent tab or last viewed as the selection.

Expected result:
Setting should be respected.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.22.103

Reproducible on current live release:
no

Additional Information

This was previously resolved with #11526

[petemill]

Great find @LaurenWags. Note for @bridiver this was because tab-detached-at does not fire for destroyed tab and also it fires after muon has changed active tab. Instead I have to revert back to manually calling setActive on will-destroy and before calling move.

[btlechowski]

Verified Win7 x64 v0.22.105

Verified on macOS 10.12.6 x64 using the following build:

• 0.22.109 5e4846e
• libchromiumcontent: 65.0.3325.181
• muon: 6.0.3

Verified on Ubuntu 17.10 x64:
0.22.109 5e4846e
libchromiumcontent: 65.0.3325.181
muon: 6.0.3